Skip to content

chore: clean up dependencies, spell check caching, and leftover markup - #4833

Merged
thetaPC merged 1 commit into
mainfrom
small-loose-ends
Nov 5, 2026
Merged

thetaPC merged 1 commit into
mainfrom
small-loose-ends

Conversation

@thetaPC

@thetaPC thetaPC commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Issue URL: N/A

What is the current behavior?

A few small leftovers: a spell check that re-reads every file, a dependency used once, a heading level skip on the glossary, dependency install scripts nobody reviewed, and dead markup from older versions of the site.

What is the new behavior?

  • npm run spellcheck uses --cache, so a repeat local run takes 4s instead of 12s. .cspellcache is gitignored
  • fs-extra is removed. scripts/release-notes.mjs was its only user and now writes the same JSON with fs.writeFileSync
  • Glossary terms are ## instead of ###, so the page no longer jumps from the h1 to h3. Anchors are unchanged
  • allowScripts in package.json denies install scripts for the 4 dependencies that have them. None are needed:
    • @parcel/watcher and fsevents ship prebuilt binaries
    • @swc/core only checks its prebuilt binary and downloads a WASM fallback if that fails
    • core-js prints a funding message
  • Removed dead markup in current and v8 docs:
    • the glossary's <div id="what-is">, left over from the pre-Docusaurus site
    • <intro-end /> on 4 pages, which nothing styles or reads

Does this introduce a breaking change?

  • Yes
  • No

Other information

npm only reports allowScripts today and will enforce it in a future release. To check that enforcement won't break anything, I installed with npm ci --ignore-scripts and built the site. The swc, parcel watcher and fsevents bindings all load.

Apart from the removed tags, the intro-end pages build to the same HTML.

The glossary terms now render at h2 size. Preview: Glossary

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-docs Ready Ready Preview Nov 5, 2026 4:36am UTC

Request Review

@ShaneK ShaneK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work! 🚀

@thetaPC
thetaPC marked this pull request as ready for review November 5, 2026 22:06
@thetaPC
thetaPC requested a review from a team as a code owner November 5, 2026 22:06
@thetaPC
thetaPC requested a review from brandyscarney November 5, 2026 22:06
@thetaPC
thetaPC merged commit 1f413af into main Nov 5, 2026
7 checks passed
@thetaPC
thetaPC deleted the small-loose-ends branch November 5, 2026 22:06

This branch was successfully deployed

1 active deployment
Preview — 1b880964 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants